Fix TKG OVA template upgrade mechanism in CSE #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
adambarreiro
requested review from
lvirbalas,
Didainius and
dataclouder
as code owners
lvirbalas
approved these changes
Apr 9, 2024
added 8 commits
April 10, 2024 10:35
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Didainius
approved these changes
Apr 12, 2024
dataclouder
reviewed
Apr 12, 2024
dataclouder
approved these changes
Apr 12, 2024
dataclouder
reviewed
Apr 12, 2024
added 6 commits
April 12, 2024 17:52
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The CSE UI Plugin allows to perform a cluster upgrade when the chosen OVA template only differs in the Kubernetes version (or in other words, the TKG version remains the same).
Our code, however, only allows to perform upgrades when both TKG version and Kubernetes version are higher, which is wrong.
This PR fixes this, by allowing the TKG version to be equal as well.
Testing
Environment: For instance, we can upload these two OVAs in the
tkgcatalog in VCD (they have both the same TKG version v2.4.0):govcd_test_config.yaml: Set
ovaName: "ubuntu-2004-kube-v1.26.8+vmware.1-tkg.1-b8c57a6c8c98d227f74e7b1a9eef27st"(the lowest Kubernetes version)Then run Test_Cse (it should take 45-150min)
Without the patch, the update is skipped and it outputs:
With the patch, upgrade should be run and the warning does not appear.